Feature/vfb loader #547
Merged
Feature/vfb loader #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddelpiano
commented
May 11, 2020
•
ddelpiano
commented
- moved the logic to handle the instances to load to reducer
- fixed issue with loading multiple instances
- fixed issue with instance already loaded never killing the loader
- fixed id= mechanism broken with the previous PR
- fixed the termInfo displaying data without waiting for 3d or slices data (note on this, on the first load this won't work since there is a whole logic built around the id= that require a deeper refactoring, i tried to hack it around but it takes too long and unless this is a priority I will try to fix this in smaller chunks as improvements with other tasks that will have to touch this logic in the future).
- other small improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.